Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reissue client keypairs on issuer change #12846

Merged
merged 1 commit into from
Nov 28, 2021
Merged

Reissue client keypairs on issuer change #12846

merged 1 commit into from
Nov 28, 2021

Conversation

johngmyers
Copy link
Member

/kind bug

Keypair was not reissuing client certificates when their issuer changed.

Fixes #12343.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 27, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/provider/openstack Issues or PRs related to openstack provider and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit 84321ad into kubernetes:master Nov 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 28, 2021
@johngmyers johngmyers deleted the resign-on-ca-change branch November 28, 2021 05:50
@johngmyers johngmyers mentioned this pull request Nov 28, 2021
Merged
k8s-ci-robot added a commit that referenced this pull request Nov 28, 2021
@k8s-ci-robot
Merge pull request #12853 from johngmyers/automated-cherry-pick-of-#1…
8270b0f 
…2846-upstream-release-1.22

Automated cherry pick of #12846: Reissue client keypairs on issuer change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

Cluster does not validate after distrusting old keypair
3 participants
@johngmyers @k8s-ci-robot @hakman