Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to etcd-manager v3.0.20220203 #13196

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Update to etcd-manager v3.0.20220203 #13196

merged 2 commits into from
Feb 3, 2022

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Feb 3, 2022

Relevant changes:

* Only emit GOMAXPROCS if non-zero [@justinsb](https://github.com/justinsb) [#284](https://github.com/kubernetes-sigs/etcdadm/pull/284)
* Set ETCD_STRICT_RECONFIG_CHECK [@justinsb](https://github.com/justinsb) [#286](https://github.com/kubernetes-sigs/etcdadm/pull/286)
* environment: ignore empty lines when converting to map [@justinsb](https://github.com/justinsb) [#285](https://github.com/kubernetes-sigs/etcdadm/pull/285)
* Fix ipv6 detection [@olemarkus](https://github.com/olemarkus) [#291](https://github.com/kubernetes-sigs/etcdadm/pull/291)
* Test for nil in to not found check [@olemarkus](https://github.com/olemarkus) [#292](https://github.com/kubernetes-sigs/etcdadm/pull/292)

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 3, 2022
@justinsb
Update to etcd-manager v3.0.20220203
97b7b90 
Relevant changes:

* Only emit GOMAXPROCS if non-zero [justinsb](https://github.com/justinsb) [284](kubernetes-sigs/etcdadm#284)
* Set ETCD_STRICT_RECONFIG_CHECK [justinsb](https://github.com/justinsb) [286](kubernetes-sigs/etcdadm#286)
* environment: ignore empty lines when converting to map [justinsb](https://github.com/justinsb) [285](kubernetes-sigs/etcdadm#285)
* Fix ipv6 detection [olemarkus](https://github.com/olemarkus) [291](kubernetes-sigs/etcdadm#291)
* Test for nil in to not found check [olemarkus](https://github.com/olemarkus) [292](kubernetes-sigs/etcdadm#292)
@justinsb
Update expected test output for etcd-manager bump
4f89c2e
@justinsb justinsb force-pushed the update_etcdmanager_3.0.20220203 branch from 2b0b7dc to 4f89c2e Compare February 3, 2022 16:22
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 3, 2022
@justinsb
Copy link
Member Author

justinsb commented Feb 3, 2022

Shouldn't pass before we promote artifacts in kubernetes/k8s.io#3349

cc @olemarkus @hakman

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 3, 2022
@justinsb
Copy link
Member Author

justinsb commented Feb 3, 2022

/test pull-kops-e2e-kubernetes-aws

@k8s-ci-robot k8s-ci-robot merged commit c2a8e8a into kubernetes:master Feb 3, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 3, 2022
This was referenced Feb 19, 2022
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Feb 20, 2022
@k8s-ci-robot
Merge pull request #13292 from justinsb/cherrypick_13196_release-1.21
f3ac07a 
Cherry pick of #13196 onto release-1.21
k8s-ci-robot added a commit that referenced this pull request Feb 20, 2022
@k8s-ci-robot
Merge pull request #13291 from justinsb/cherrypick_13196_release-1.22
524fcca 
Cherry pick of #13196 onto release-1.22
@hakman hakman mentioned this pull request Feb 25, 2022
Merged
k8s-ci-robot added a commit that referenced this pull request Feb 25, 2022
@k8s-ci-robot
Merge pull request #13307 from hakman/automated-cherry-pick-of-#13196…
fe2041c 
…-upstream-release-1.23

Automated cherry pick of #13196: Update to etcd-manager v3.0.20220203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@mikesplain mikesplain Awaiting requested review from mikesplain

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justinsb @k8s-ci-robot @hakman