Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCP API health checks #13199

Merged
merged 5 commits into from Feb 16, 2022
Merged

GCP API health checks #13199

merged 5 commits into from Feb 16, 2022

Conversation

zetaab
Copy link
Member

@zetaab zetaab commented Feb 3, 2022

fixes #13182

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 3, 2022
@k8s-ci-robot k8s-ci-robot added the area/provider/gcp Issues or PRs related to gcp provider label Feb 3, 2022
@zetaab zetaab changed the title wip: GCP API health checks GCP API health checks Feb 3, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2022
@zetaab
Copy link
Member Author

zetaab commented Feb 7, 2022

@rifelpet could you check this?

zetaab and others added 2 commits February 7, 2022 21:32
@zetaab @rifelpet
Update pkg/model/gcemodel/api_loadbalancer.go
180c3ae 
Co-authored-by: Peter Rifel <rifelpet@users.noreply.github.com>
@zetaab
add missing import
3e505a5
@zetaab zetaab requested a review from rifelpet February 15, 2022 08:13
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit e5f75e0 into kubernetes:master Feb 16, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 16, 2022
@zetaab zetaab deleted the addhealthcheck branch February 16, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet approved these changes

@joshbranham joshbranham Awaiting requested review from joshbranham

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

Kube API LB monitors missing in GCE
3 participants
@zetaab @k8s-ci-robot @rifelpet