New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup GCP Cluster Service Accounts #13201
Conversation
eebf18e
to
1c82d64
Compare
/cc @justinsb as you forgot to implement this when you added service accounts :) |
/assign @justinsb |
/test pull-kops-e2e-k8s-gce |
@rifelpet @hakman @olemarkus could someone help reviewing this? |
@rifelpet I added const now under gce package. No idea is there better place for these as this is quite "common" in all cloudproviders. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes #13200