Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSI migration feature gates #13203

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

olemarkus
Copy link
Member

@olemarkus olemarkus commented Feb 4, 2022

We had a bug for KCM feature gate, and the scheuler and apiserver gate was missing entirely.

fixes #13197

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 4, 2022
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/nodeup and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 4, 2022
We had a bug for KCM feature gate, and the scheuler and apiserver gate was missing entirely.
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2022
@hakman
Copy link
Member

hakman commented Feb 5, 2022

/lgtm
/cc @johngmyers

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2022
k8s-ci-robot added a commit that referenced this pull request Feb 8, 2022
…203-origin-release-1.21

Automated cherry pick of #13203: Fix CSI migration feature gates
@k8s-ci-robot k8s-ci-robot merged commit 1470528 into kubernetes:master Feb 8, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 8, 2022
k8s-ci-robot added a commit that referenced this pull request Feb 8, 2022
…203-origin-release-1.23

Automated cherry pick of #13203: Fix CSI migration feature gates
k8s-ci-robot added a commit that referenced this pull request Feb 8, 2022
…203-origin-release-1.22

Automated cherry pick of #13203: Fix CSI migration feature gates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detaching massively EBS volumes after CSI installed
3 participants