Fix irsa for k8s < 1.20 #13212
Merged
Fix irsa for k8s < 1.20 #13212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
the
needs-rebase
|
@olemarkus Could you split this into 2 commits so that at least the main one would be easy to track in various branches? |
hakman
reviewed
Feb 9, 2022
hakman
reviewed
Feb 9, 2022
pkg/apis/kops/validation/legacy.go
Outdated
| } | ||
| } | ||
| } | ||
| if said.EnableAWSOIDCProvider { |
There was a problem hiding this comment.
Let's just add this a as separate block, if you don't mind.
Suggested change
| if said.EnableAWSOIDCProvider { | |
| if said != nil && said.EnableAWSOIDCProvider { |
There was a problem hiding this comment.
The said stuff was getting too big. Moved to a dedicated function.
|
/test pull-kops-e2e-kubernetes-aws |
|
/retest |
hakman
approved these changes
Feb 9, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Feb 9, 2022
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 10, 2022
…212-origin-release-1.22 Automated cherry pick of #13212: Fix irsa for k8s < 1.20
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 10, 2022
…212-origin-release-1.23 Automated cherry pick of #13212: Fix irsa for k8s < 1.20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IRSA on 1.19 segfaults because we are not setting the feature gate that the aws model expects.