Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing permissions to aws lbc for irsa #13280

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Add missing permissions to aws lbc for irsa #13280

merged 1 commit into from
Feb 18, 2022

Conversation

olemarkus
Copy link
Member

@olemarkus olemarkus commented Feb 17, 2022 •
edited
Loading

Looks like we are missing a lot of permissions for LBC.
fixes #13020

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 17, 2022
@olemarkus
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@olemarkus: The following commands are available to trigger required jobs:

  • /test pull-e2e-kops-addon-resource-tracking
  • /test pull-e2e-kops-aws-load-balancer-controller
  • /test pull-e2e-kops-metrics-server
  • /test pull-kops-bazel-build
  • /test pull-kops-bazel-test
  • /test pull-kops-e2e-arm64
  • /test pull-kops-e2e-aws-apiserver-nodes
  • /test pull-kops-e2e-aws-cloud-controller-manager
  • /test pull-kops-e2e-aws-ebs-csi-driver
  • /test pull-kops-e2e-aws-external-dns
  • /test pull-kops-e2e-aws-karpenter
  • /test pull-kops-e2e-cni-amazonvpc
  • /test pull-kops-e2e-cni-amazonvpc-ipv6
  • /test pull-kops-e2e-cni-calico
  • /test pull-kops-e2e-cni-calico-ipv6
  • /test pull-kops-e2e-cni-canal
  • /test pull-kops-e2e-cni-cilium
  • /test pull-kops-e2e-cni-cilium-etcd
  • /test pull-kops-e2e-cni-cilium-ipv6
  • /test pull-kops-e2e-cni-flannel
  • /test pull-kops-e2e-cni-kuberouter
  • /test pull-kops-e2e-cni-weave
  • /test pull-kops-e2e-k8s-amzn2
  • /test pull-kops-e2e-k8s-ci
  • /test pull-kops-e2e-k8s-ci-ha
  • /test pull-kops-e2e-k8s-debian10
  • /test pull-kops-e2e-k8s-debian11
  • /test pull-kops-e2e-k8s-docker
  • /test pull-kops-e2e-k8s-gce
  • /test pull-kops-e2e-k8s-gce-calico-u2004-k22-containerd
  • /test pull-kops-e2e-k8s-gce-ci
  • /test pull-kops-e2e-k8s-ubuntu2110
  • /test pull-kops-e2e-k8s-ubuntu2204
  • /test pull-kops-e2e-kubernetes-aws
  • /test pull-kops-e2e-kubernetes-do-kubetest2
  • /test pull-kops-verify-bazel
  • /test pull-kops-verify-boilerplate
  • /test pull-kops-verify-cloudformation
  • /test pull-kops-verify-generated
  • /test pull-kops-verify-gofmt
  • /test pull-kops-verify-golangci-lint
  • /test pull-kops-verify-gomod
  • /test pull-kops-verify-govet
  • /test pull-kops-verify-hashes
  • /test pull-kops-verify-terraform

Use /test all to run the following jobs that were automatically triggered:

  • pull-kops-bazel-build
  • pull-kops-bazel-test
  • pull-kops-e2e-cni-amazonvpc
  • pull-kops-e2e-cni-calico
  • pull-kops-e2e-cni-calico-ipv6
  • pull-kops-e2e-cni-cilium
  • pull-kops-e2e-cni-cilium-ipv6
  • pull-kops-e2e-kubernetes-aws
  • pull-kops-verify-bazel
  • pull-kops-verify-boilerplate
  • pull-kops-verify-cloudformation
  • pull-kops-verify-generated
  • pull-kops-verify-gofmt
  • pull-kops-verify-golangci-lint
  • pull-kops-verify-gomod
  • pull-kops-verify-govet
  • pull-kops-verify-terraform

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@olemarkus
Copy link
Member Author

/test pull-e2e-kops-aws-load-balancer-controller

@johngmyers
Copy link
Member

/retest

hakman
hakman requested changes Feb 18, 2022
View reviewed changes
pkg/model/iam/iam_builder.go Outdated Show resolved Hide resolved
pkg/model/iam/iam_builder.go Outdated Show resolved Hide resolved
@hakman
Copy link
Member

hakman commented Feb 18, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2022
@olemarkus
Copy link
Member Author

/test pull-e2e-kops-aws-load-balancer-controller

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2022
@hakman
Copy link
Member

hakman commented Feb 18, 2022

/test pull-e2e-kops-aws-load-balancer-controller

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2022
@olemarkus
Copy link
Member Author

/test pull-e2e-kops-aws-load-balancer-controller

@olemarkus
Copy link
Member Author

/test pull-e2e-kops-aws-load-balancer-controller

@olemarkus
Copy link
Member Author

/retest

1 similar comment
@olemarkus
Copy link
Member Author

/retest

@olemarkus
Copy link
Member Author

Not sure how we managed to get this test passing before, but the test tries to use create an LB with the cluster name in it. This name contains ., which is not allowed by AWS.

@hakman
Copy link
Member

hakman commented Feb 18, 2022

Not sure how we managed to get this test passing before, but the test tries to use create an LB with the cluster name in it. This name contains ., which is not allowed by AWS.

Seems like a test bug and should be fixed in k/k. Should we skip it for now?

@olemarkus
Copy link
Member Author

The tests are from lbc repo, but yeah. we I'll do rebase and push, and then we skip trying to run that test. I'll see if I can fix it in a follow-up.

@hakman
Copy link
Member

hakman commented Feb 18, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2022
This was referenced Feb 18, 2022
Merged
Merged
@olemarkus
Copy link
Member Author

/retest

k8s-ci-robot added a commit that referenced this pull request Feb 18, 2022
@k8s-ci-robot
Merge pull request #13287 from olemarkus/automated-cherry-pick-of-#13…
0ebfcc6 
…280-origin-release-1.23

Automated cherry pick of #13280: Add missing permissions to aws lbc for irsa
k8s-ci-robot added a commit that referenced this pull request Feb 18, 2022
@k8s-ci-robot
Merge pull request #13288 from olemarkus/automated-cherry-pick-of-#13…
7302727 
…280-origin-release-1.22

Automated cherry pick of #13280: Add missing permissions to aws lbc for irsa
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 18, 2022 •
edited
Loading

@olemarkus: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-kops-aws-load-balancer-controller 40939ee link true /test pull-e2e-kops-aws-load-balancer-controller

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@olemarkus
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit a8ceb30 into kubernetes:master Feb 18, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 18, 2022
@olemarkus olemarkus mentioned this pull request Mar 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@joshbranham joshbranham Awaiting requested review from joshbranham

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

AWS LBC cannot delete Security Groups it creates
4 participants
@olemarkus @k8s-ci-robot @johngmyers @hakman