Move Openstack settings to cloudProvider.openstack

[johngmyers]

No description provided.

[johngmyers]

/retest

[k8s-ci-robot]

@johngmyers: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kops-e2e-cni-amazonvpc	be4724c	link	true	/test pull-kops-e2e-cni-amazonvpc

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[justinsb]

Did we lose the nil checks here?

One thing we could do is introduce nil-safe getters, like GetOpenstack(), which would look a bit like this:

func (c *CloudProvider) GetOpenstack() *OpenStack {
  if c == nil {
    return nil
  }
  return c.Openstack
}

Or alternatively:

func (c *CloudProvider) GetOpenstack() *Openstack {
  if c == nil || c.Openstack == nil {
    return &Openstack{}
  }
  return c.Openstack
}

The virtue of the second one is that it forces us to not rely on nil as being meaningful. Of course that's a fairly significant change, but it might be a good thing to think about for v1alpha3!

[johngmyers]

This ModelBuilder won't even be instantiated unless Spec.CloudProvider.Openstack is non-nil.

[justinsb]

One nit and a few ideas, but LGTM from a code perspective.

We should get OpenStack folk to look at this before merging though :-) But looks really good for a WIP!

[zetaab]

for me this looks ok

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [zetaab]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment