Allow cluster autoscaler to read EC2 instance types to build catalog dynamically #13532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
olemarkus
approved these changes
Apr 20, 2022
k8s-ci-robot
added
lgtm
When the cluster autoscaler builds its EC2 instance type catalog dynamically instead of using only its statically defined set, grant it the additional IAM permissions required to fetch the instance types from the AWS API.
seh
force-pushed
the
augment-cluster-autoscaler-iam-permissions-conditionally
branch
from
fb5f60f
to
de1ecd8
Compare
k8s-ci-robot
removed
the
lgtm
hakman
approved these changes
Apr 20, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 21, 2022
…igin-release-1.23 Automated cherry pick of #13532: Allow cluster autoscaler to get EC2 instance types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the cluster autoscaler builds its EC2 instance type catalog dynamically instead of using only its statically defined set, grant it the additional IAM permissions—as prescribed in the cluster autoscaler documentation—required to fetch the instance types from the AWS API.
Fixes #13520.