Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid spurious changes with ed25519 keys #13774

Merged
merged 1 commit into from Jun 11, 2022

Conversation

hakman
Copy link
Member

@hakman hakman commented Jun 11, 2022

Trying to fix the issue described in #13768 (comment).

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 11, 2022
@hakman
Copy link
Member Author

hakman commented Jun 11, 2022

/test pull-kops-e2e-aws-upgrade-123-ko123-to-klatest-kolatest

@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Jun 11, 2022
@hakman
Copy link
Member Author

hakman commented Jun 11, 2022

/cc @rifelpet @olemarkus

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2022
@hakman
Copy link
Member Author

hakman commented Jun 11, 2022

/retest

@hakman
Copy link
Member Author

hakman commented Jun 11, 2022

/test all

@k8s-ci-robot
Copy link
Contributor

@hakman: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-aws-upgrade-123-ko123-to-klatest-kolatest f6a2ce8 link false /test pull-kops-e2e-aws-upgrade-123-ko123-to-klatest-kolatest

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 368c72b into kubernetes:master Jun 11, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 11, 2022
k8s-ci-robot added a commit that referenced this pull request Jun 12, 2022
…-upstream-release-1.23

Automated cherry pick of #13774: Avoid spurious changes with ed25519 keys
k8s-ci-robot added a commit that referenced this pull request Jun 12, 2022
…-upstream-release-1.24

Automated cherry pick of #13774: Avoid spurious changes with ed25519 keys
@hakman hakman deleted the fix_ed25519 branch July 2, 2022 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants