Add missing namespace to external-dns Service #14001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
hakman
approved these changes
Jul 19, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
external-dns e2e job started failing recently. The external-dns pods are never created and protokube reports these logs:
I0718 22:38:45.861661 6318 apply.go:70] applying objects of kind: Deployment.appsI0718 22:38:45.868537 6318 apply.go:116] updating apps/v1, Resource=deployments kube-system/external-dnsI0718 22:38:45.876239 6318 apply.go:70] applying objects of kind: ServiceI0718 22:38:45.883606 6318 apply.go:123] creating /v1, Resource=services /external-dns updating "external-dns.addons.k8s.io": error applying update from "s3://k8s-kops-prow/e2e-e2e-kops-aws-external-dns.test-cncf-aws.k8s.io/addons/external-dns.addons.k8s.io/k8s-1.19.yaml": failed to apply objects of kind Service: failed to create /external-dns: the server does not allow this method on the requested resourceW0718 22:38:45.889276 3464 kube_boot.go:89] error applying channel "s3://k8s-kops-prow/e2e-e2e-kops-aws-external-dns.test-cncf-aws.k8s.io/addons/bootstrap-channel.yaml": error running channels: exit status 1Notice the
/external-dnsresource name whereas the Deployment haskube-system/external-dns. This leads me to believe the Service is missing the namespace field.