Create NLB instead of CLB for bastion #14468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/documentation
area/provider/aws
hakman
reviewed
Oct 28, 2022
johngmyers
force-pushed
the
bastion-nlb
branch
from
826ff18
to
5b25e60
Compare
|
/cc @rifelpet |
johngmyers
force-pushed
the
bastion-nlb
branch
from
5b25e60
to
1f3571f
Compare
johngmyers
force-pushed
the
bastion-nlb
branch
from
1f3571f
to
25b7dc2
Compare
hakman
approved these changes
Nov 5, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bastions didn't work in IPv6 clusters because they were placed in the IPv6-only private networks, which the CLB couldn't talk to. IPv6 bastions are now placed in dualstack networks, where they can be instance targets.
While I was at it, I switched the bastion LB from CLB to NLB. If there are any subnets with IPv6 CIDRs, it makes the NLB dualstack and publishes an AAAA DNS record for it.
Doesn't delete the old CLB (yet).