aws: Add capacityRebalance flag for ASGs #14583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/api
area/provider/aws
johngmyers
reviewed
Nov 18, 2022
hakman
requested changes
Nov 18, 2022
|
Can you also add release notes and docs? |
hakman
changed the title
k8s-ci-robot
added
area/documentation
needs-rebase
heybronson
force-pushed
the
capacity-rebalance
branch
from
f54cef2
to
06c85b7
Compare
heybronson
requested review from
hakman and
johngmyers
and removed request for
mikesplain,
joshbranham and
hakman
k8s-ci-robot
added
needs-rebase
heybronson
force-pushed
the
capacity-rebalance
branch
from
7282aea
to
71c0f70
Compare
hakman
requested changes
Nov 22, 2022
Co-authored-by: Ciprian Hacman <ciprian@hakman.dev>
|
Thanks @heybronson. Please also squash the commits. |
k8s-ci-robot
added
the
lgtm
|
Actually, it looks fine. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes a new
CapacityRebalanceflag which enables/disables ASG capacity rebalancing: https://docs.aws.amazon.com/autoscaling/ec2/userguide/ec2-auto-scaling-capacity-rebalancing.htmlThis is very helpful for users who have spot instanceGroups and want to proactively have ASG replace instances that have received a rebalance recommendation (meaning they're at elevated risk of interruption by AWS).