New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add inadvertently-dropped deprecation notices #14596
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
2 similar comments
/retest |
/retest |
@johngmyers Seems that something is broken with kubelet, probably when populating the API server URL:
|
I have not been able to reproduce this in my own environment. |
I have been able to reproduce, but don't understand why it happens yet. On new nodes, |
/lgtm cancel |
597fcd7
to
f8d9ae2
Compare
I think it's running a kops built off of the branch against a nodeup built off of the presumed merge or vice versa. |
Seems similar to what I managed to find. Let's see if manual rebase helped. |
#14566 was able to bring the cluster up after a rebase. |
Maybe something is broken with automated rebase? |
I suspect pull-kops-build is misconfigured. |
If it would be misconfigured, manual rebase would not help use the correct nodeup binary. |
It could be that a rebase causes pull-kops-build to rerun and update nodeup, whereas another PR landing on master doesn't. |
|
Okay, I'm not sure what uploads nodeup to the bucket. |
Each job uploads its own build to the bucket, diferent dirs. Not very optimal, but works ok. |
No description provided.