Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add inadvertently-dropped deprecation notices #14596

Merged
merged 1 commit into from Nov 19, 2022

Conversation

johngmyers
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2022
@hakman
Copy link
Member

hakman commented Nov 19, 2022

/retest

2 similar comments
@johngmyers
Copy link
Member Author

/retest

@johngmyers
Copy link
Member Author

/retest

@hakman
Copy link
Member

hakman commented Nov 19, 2022

@johngmyers Seems that something is broken with kubelet, probably when populating the API server URL:

E1119 02:45:17.151948    6143 run.go:74] "command failed" err="failed to run Kubelet:
  failed to initialize kubelet client: host must be a URL or a host:port pair: \"https://\""

@johngmyers
Copy link
Member Author

I have not been able to reproduce this in my own environment.

@hakman
Copy link
Member

hakman commented Nov 19, 2022

I have not been able to reproduce this in my own environment.

I have been able to reproduce, but don't understand why it happens yet. On new nodes, /var/lib/kubelet/kubeconfig has clusters[0].cluster.server: https://.

@hakman
Copy link
Member

hakman commented Nov 19, 2022

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2022
@kubernetes kubernetes deleted a comment from k8s-triage-robot Nov 19, 2022
@johngmyers
Copy link
Member Author

I think it's running a kops built off of the branch against a nodeup built off of the presumed merge or vice versa.

@hakman
Copy link
Member

hakman commented Nov 19, 2022

Seems similar to what I managed to find. Let's see if manual rebase helped.

@johngmyers
Copy link
Member Author

#14566 was able to bring the cluster up after a rebase.

@hakman
Copy link
Member

hakman commented Nov 19, 2022

Maybe something is broken with automated rebase?

@johngmyers
Copy link
Member Author

I suspect pull-kops-build is misconfigured.

@hakman
Copy link
Member

hakman commented Nov 19, 2022

If it would be misconfigured, manual rebase would not help use the correct nodeup binary.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2022
@johngmyers
Copy link
Member Author

It could be that a rebase causes pull-kops-build to rerun and update nodeup, whereas another PR landing on master doesn't.

@hakman
Copy link
Member

hakman commented Nov 19, 2022

pull-kops-build doesn't actually push things (or at least it's not supposed to).

@johngmyers
Copy link
Member Author

Okay, I'm not sure what uploads nodeup to the bucket.

@hakman
Copy link
Member

hakman commented Nov 19, 2022

Each job uploads its own build to the bucket, diferent dirs. Not very optimal, but works ok.

@k8s-ci-robot k8s-ci-robot merged commit 7a5e616 into kubernetes:master Nov 19, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 19, 2022
@johngmyers johngmyers deleted the deprecation branch November 19, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants