Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubetest: dump poddisruptionbudgets and fieldManagers #14624

Merged
merged 1 commit into from Nov 22, 2022
Merged

kubetest: dump poddisruptionbudgets and fieldManagers #14624

merged 1 commit into from Nov 22, 2022

Conversation

justinsb
Copy link
Member

Should help diagnose what's going on in some of our complex upgrade
tests when we detect conflicts.

Issue #14520

@justinsb
kubetest: dump poddisruptionbudgets and fieldManagers
f887d51 
Should help diagnose what's going on in some of our complex upgrade
tests when we detect conflicts.

Issue kubernetes#14520
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 22, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 22, 2022
@justinsb
Copy link
Member Author

The test which should be doing the same thing as the failing upgrade tests is not showing a problem (#14623).

Adding more information to our dump so we can better understand what's going on here.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2022
@justinsb
Copy link
Member Author

Thanks @olemarkus - I think I found the fix as well - I added the original kubectl apply -f applier to the tests and was able to get a failure, fix should be #14626

@justinsb
Copy link
Member Author

(Although we still want this PR, because the test just passed but I'm not sure why...)

@k8s-ci-robot k8s-ci-robot merged commit d69e61f into kubernetes:master Nov 22, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus olemarkus approved these changes

@joshbranham joshbranham Awaiting requested review from joshbranham

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

Assignees

@olemarkus olemarkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justinsb @k8s-ci-robot @olemarkus