Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SELinuxMount feature gate #14628

Merged
merged 2 commits into from Nov 23, 2022

Conversation

jsafrane
Copy link
Member

Add a new feature gate SELinuxMount that configures AWS EBS CSI driver installed by kOps for SELinuxMount support.

  • It projects necessary SELinux /etc and /sys directories from the host to the CSI driver (see KEP for details)
  • It sets CSIDriver.Spec.SELinuxMount: true

I added KopsFeatureEnabled function to templates to have a nice {{ if KopsFeatureEnabled "SELinuxMount" }} there.

`KopsFeatureEnabled "Foo"` returns true, if a feature "Foo" is enabled in
kops (i.e. KOPS_FEATURE_FLAGS).
This feature installs platform CSI drivers so they support
SELinuxMountReadWriteOncePod. This assumes the operating system on all
nodes supports SELinux!
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 22, 2022
@k8s-ci-robot k8s-ci-robot added area/addons size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 22, 2022
@hakman hakman changed the title Add SELinuxMount feature gate. Add SELinuxMount feature gate Nov 23, 2022
@hakman
Copy link
Member

hakman commented Nov 23, 2022

/lgtm
/assign @olemarkus

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2022
@olemarkus
Copy link
Member

/retest

@k8s-ci-robot
Copy link
Contributor

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-k8s-gce-cilium e969b84 link unknown /test pull-kops-e2e-k8s-gce-cilium
pull-kops-e2e-k8s-aws-calico e969b84 link unknown /test pull-kops-e2e-k8s-aws-calico

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@johngmyers
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit b8987e3 into kubernetes:master Nov 23, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants