e2e: always upload to a versioned directory #14640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/wip while we make sure the e2e does what I think it should! |
justinsb
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
justinsb
force-pushed
the
e2e_upload_versioned
branch
from
5418a1a
to
19b7aa9
Compare
Otherwise on our first upload we were truncating one level of the upload path. Issue kubernetes#14639
justinsb
force-pushed
the
e2e_upload_versioned
branch
from
19b7aa9
to
b631e91
Compare
k8s-ci-robot
added
size/M
We were including the full URL, rather than just the last component. Technically we could still have overly-long filenames, it shouldn't happen though.
justinsb
force-pushed
the
e2e_upload_versioned
branch
from
f617f83
to
c407063
Compare
hakman
requested review from
olemarkus and
rifelpet
and removed request for
KashifSaadat
|
/test pull-kops-e2e-k8s-aws-calico It's passing, but the whole point is that it should pass again :-) |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
justinsb
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise on our first upload we were truncating one level of the
upload path.
Issue #14639