Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scaleway: get credentials from Scaleway profile #15122

Merged
merged 1 commit into from Feb 24, 2023

Conversation

Mia-Cross
Copy link
Contributor

The Scaleway Developer Tools ecosystem allows users to define profiles in a yaml file that looks like this :

profiles:
  default-profile:
    access_key: SCWXXXXXXXXXXXXXXXX
    secret_key: xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx
    default_project_id: xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx
    default_zone: fr-par-1
    default_region: fr-par

This PR adds the possibility for kOps to get the credentials from this file rather than from the environment by defining SCW_PROFILE=default-profile in the environment.

They can still choose to provide their credentials by defining SCW_ACCESS_KEY, SCW_SECRET_KEY and SCW_DEFAULT_PROJECT_ID but I will update the documentation in #14735 in order to encourage them to use the profiles instead since it's more secure.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/nodeup labels Feb 10, 2023
@k8s-ci-robot k8s-ci-robot added area/provider/scaleway Issues or PRs related to Scaleway provider size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 10, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Mia-Cross. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 10, 2023
@hakman
Copy link
Member

hakman commented Feb 11, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 11, 2023
@hakman
Copy link
Member

hakman commented Feb 11, 2023

/retest

Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a good approach. Thanks @Mia-Cross.
I think we are getting close now :).

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit b5dc9f6 into kubernetes:master Feb 24, 2023
@Mia-Cross Mia-Cross deleted the scw_profiles branch February 27, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup area/provider/scaleway Issues or PRs related to Scaleway provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants