-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MemorySwap #15352
Add support for MemorySwap #15352
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @tomesm. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tomesm If you have time to go through the review, please let me know and I will try to review this PR. |
Thanks, @tomesm for the inspiration and sorry for the delay in review. |
Hey @hakman , your version looks better. Im glad I inspired you :) |
I hope you try again @tomesm. I would be happy to review your PRs. 👍 |
This PR adds support for
MemorySwapConfiguration
based on the following logic:memorySwapConfiguration.swapBehavior
is not set, there will be no change to the kubelet configuration.memorySwapConfiguration.swapBehavior
is set to an empty string, kubelet config will containmemorySwap: ""
.memorySwapConfiguration.swapBehavior
is set to"UnlimitedSwap"
, kubelet config will containmemorySwap: UnlimitedSwap
.Fixes: #14950