If the Cluster Name is not default the hubble relay shows TLS errors

[s3than]

This change uses the ClusterName value to correctly set the dnsName for certificate generation

Updated Files

• Update: upup/models/cloudup/resources/addons/networking.cilium.io/k8s-1.16-v1.12.yaml.template

[k8s-ci-robot]

Hi @s3than. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hakman]

/ok-to-test

[s3than]

/retest

[s3than]

/retest

[s3than]

@hakman Apologies I'm not sure what's needed from this point ...

 Summarizing 1 Failure:
  [FAIL] [sig-api-machinery] CustomResourcePublishOpenAPI [Privileged:ClusterAdmin] [It] works for multiple CRDs of different groups [Conformance]
  test/e2e/apimachinery/crd_publish_openapi.go:284
Ran 855 of 7486 Specs in 996.843 seconds
FAIL! -- 854 Passed | 1 Failed | 0 Pending | 6631 Skipped 

Could you point me in the right direction please

[hakman]

/retest

[s3than]

@hakman If it fails again should I look at the flakes item and go that way? Thanks again

[hakman]

@s3than Failures are coming from kubernetes/kubernetes#117363. All we can do until the next K8s release is to /retest.

[hakman]

@olemarkus Any chance you can take a look at this?
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [olemarkus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hakman]

/retest

[k8s-triage-robot]

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

• The PR does have any do-not-merge/* labels
• The PR does not have the needs-ok-to-test label
• The PR is mergeable (does not have a needs-rebase label)
• The PR is approved (has cncf-cla: yes, lgtm, approved labels)
• The PR is failing tests required for merge

You can:

• Review the full test history for this PR
• Prevent this bot from retesting with /lgtm cancel or /hold
• Help make our tests less flaky by following our Flaky Tests Guide

/retest