upload helper: support upload to S3 buckets that block ACLs #15368
Conversation
Similar to GCS with UBLA, S3 is now encouraging buckets that block ACLs. When we upload to one of these buckets, we cannot set ACLs. When we detect one of these buckets, we simply skip setting the ACL, assuming the object ACLs are instead managed at the bucket level, when the bucket was created.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
/test pull-kops-e2e-k8s-aws-calico /test pull-kops-e2e-k8s-gce-cilium |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
|
/retest |
|
@justinsb: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test pull-kops-e2e-k8s-gce-ipalias |
Similar to GCS with UBLA, S3 is now encouraging buckets that block
ACLs. When we upload to one of these buckets, we cannot set ACLs.
When we detect one of these buckets, we simply skip setting the ACL,
assuming the object ACLs are instead managed at the bucket level, when
the bucket was created.