Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #15393: scaleway: dns support #15546

Conversation

hakman
Copy link
Member

@hakman hakman commented Jun 23, 2023

Cherry pick of #15393 on release-1.27.

#15393: added domain to vendor

For details on the cherry pick process, see the cherry pick requests page.


@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jun 23, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 23, 2023
@k8s-ci-robot k8s-ci-robot added area/documentation area/provider/scaleway Issues or PRs related to Scaleway provider size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 23, 2023
@hakman hakman changed the title Automated cherry pick of #15393: added domain to vendor Automated cherry pick of #15393: scaleway: dns support Jun 23, 2023
@justinsb
Copy link
Member

/approve
/lgtm

Thanks for cherry-picking @hakman

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit a2b558e into kubernetes:release-1.27 Jun 30, 2023
13 checks passed
@hakman hakman deleted the automated-cherry-pick-of-#15393-upstream-release-1.27 branch August 7, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/documentation area/provider/scaleway Issues or PRs related to Scaleway provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants