Don't download container runtime assets when skipping the installation #15579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
johngmyers
reviewed
Jul 2, 2023
Comment on lines
+1089
to
+1094
| if err != nil { | ||
| return err | ||
| } | ||
| if dockerAssetUrl != nil && dockerAssetHash != nil { | ||
| c.Assets[arch] = append(c.Assets[arch], mirrors.BuildMirroredAsset(dockerAssetUrl, dockerAssetHash)) | ||
| } |
There was a problem hiding this comment.
In the future, it might be worth extracting this out to a method, possibly a reciever on assetBuilder. The method would take a func(Cluster, assetBuillder, arch) (url, hash, error)
There was a problem hiding this comment.
Yep, should be pretty easy.
johngmyers
approved these changes
Jul 2, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added a commit
that referenced
this pull request
Jul 3, 2023
…-upstream-release-1.27 Automated cherry pick of #15579: Don't download containerd assets when skipping the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, this only works when
SkipInstall=trueis set at cluster level.Closes #15558