Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove kube-dns-autoscaler when upgrading to CoreDNS #15584

Merged

Conversation

agilgur5
Copy link
Contributor

@agilgur5 agilgur5 commented Jul 2, 2023

Summary

Per #6318 (comment) and related comments, the kube-dns-autoscaler is no longer needed when upgrading to CoreDNS.

Details

  • there is a separate coredns-autoscaler that is spun up in more recent kOps versions

    • so the kube-dns-autoscaler is no longer needed after an upgrade to CoreDNS - and possibly could conflict if they both targeted the same deployment
  • updating the kube-dns-autoscaler was the most confusing part, so this simplifies things a good bit!

  • also fix some minor inconsistent spacing in this doc

Misc

Was teaching folks about k8s DNS so came back to the issue to see what the progress was w/ CoreDNS as I had to do this upgrade a couple years ago

- there is a separate `coredns-autoscaler` that is spun up in more recent kOps versions
  - so the `kube-dns-autoscaler` is no longer needed after an upgrade to CoreDNS
    - and possibly could conflict if they both targeted the same deployment

- updating the `kube-dns-autoscaler` was the most confusing part, so this simplifies things a good bit!
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 2, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @agilgur5. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @agilgur5. Should be very useful for those that upgrade clusters.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2023
@hakman
Copy link
Member

hakman commented Jul 3, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit e363128 into kubernetes:master Jul 3, 2023
22 checks passed
@agilgur5 agilgur5 deleted the docs-remove-kube-dns-autoscaler branch July 3, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants