kops-controller: create IPAM controller for GCE #15591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
area/kops-controller
size/L
|
This is necessary (but not sufficient) for IPv6 support on GCP. (First in a sequence of PRs.) |
johngmyers
requested changes
Jul 5, 2023
cmd/kops-controller/main.go
Outdated
| if err != nil { | ||
| return fmt.Errorf("error creating aws IPAM controller: %w", err) | ||
| } | ||
| if err := ipamController.SetupWithManager(mgr); err != nil { |
There was a problem hiding this comment.
Bottom-factor this out of the switch statement?
There was a problem hiding this comment.
Had to define an interface, but - done!
johngmyers
reviewed
Jul 5, 2023
johngmyers
reviewed
Jul 5, 2023
We observe the IPv6 CIDRs assigned to nodes, and reflect them into the node. Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>
johngmyers
approved these changes
Jul 5, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We observe the IPv6 CIDRs assigned to nodes, and reflect them into the node.