Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: revise the bastion ssh guideline to mitigate permission denied errors #15657

Merged
merged 1 commit into from Jul 18, 2023
Merged

docs: revise the bastion ssh guideline to mitigate permission denied errors #15657

merged 1 commit into from Jul 18, 2023

Conversation

techieforfun
Copy link
Contributor

  • Updated the username variable to avoid encountering the "Permission denied (publickey)" error in different AMIs
  • Removed redundant description.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 17, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @techieforfun. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hakman
Copy link
Member

hakman commented Jul 17, 2023

/cc @johngmyers

@justinsb
Copy link
Member

Thanks @techieforfun - these changes lgtm!

/ok-to-test
/lgtm
/approve

/hold for a few hours to give others a chance to review, but lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 17, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2023
johngmyers
johngmyers requested changes Jul 18, 2023
View reviewed changes
Copy link
Member

@johngmyers johngmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Access when using gossip" section also applies to none-dns. This isn't a blocking comment.

docs/bastion.md Outdated Show resolved Hide resolved
docs/bastion.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2023
@hakman
Copy link
Member

hakman commented Jul 18, 2023

@techieforfun Could you also squash the commits? Thanks!

@techieforfun @johngmyers
docs: add description to username to prevent public key permission de…
9dd1af4 
…nied error

Update docs/bastion.md

Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>

Update docs/bastion.md

Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>
@techieforfun
Copy link
Contributor Author

it's ready @hakman

@hakman
Copy link
Member

hakman commented Jul 18, 2023

Thanks @techieforfun!
/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2023
@johngmyers
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0cd216b into kubernetes:master Jul 18, 2023
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman Awaiting requested review from hakman

@olemarkus olemarkus Awaiting requested review from olemarkus

@johngmyers johngmyers Awaiting requested review from johngmyers

Assignees

@justinsb justinsb

@johngmyers johngmyers

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@techieforfun @k8s-ci-robot @hakman @justinsb @johngmyers