Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update channels #15660

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Update channels #15660

merged 1 commit into from
Jul 18, 2023

Conversation

hakman
Copy link
Member

@hakman hakman commented Jul 18, 2023

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/channels labels Jul 18, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 18, 2023
@hakman
Copy link
Member Author

hakman commented Jul 18, 2023

/cc @moshevayner

@johngmyers
Copy link
Member

Shouldn't we wait a bit before updating stable?

@hakman
Copy link
Member Author

hakman commented Jul 18, 2023

Shouldn't we wait a bit before updating stable?

  • images are tested in this PR
  • only bumped kOps to 1.26.5 in stable

What would you prefer to hold back?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2023
@hakman
Copy link
Member Author

hakman commented Jul 18, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, moshevayner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2023
@hakman
Copy link
Member Author

hakman commented Jul 18, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit aa584af into kubernetes:master Jul 18, 2023
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/channels cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants