New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
verify-boilerplate: stricter error checking #15665
verify-boilerplate: stricter error checking #15665
Conversation
If python isn't found, without this fix the script exits with code 0, despite not checking boilerplate.
This addresses the underlying reason why boilerplate was not being checked.
Figured I should probably fix the test also, not just break it, so version-bumped to |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
/test pull-kops-build |
/retest |
If python isn't found, without this fix the script exits with code 0,
despite not checking boilerplate.