Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1alpha3: Remove no-longer-used topology fields #15676

Merged
merged 2 commits into from
Jul 19, 2023
Merged

v1alpha3: Remove no-longer-used topology fields #15676

merged 2 commits into from
Jul 19, 2023

Conversation

johngmyers
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 19, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2023
@hakman
Copy link
Member

hakman commented Jul 19, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit 59ced8c into kubernetes:master Jul 19, 2023
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 19, 2023
@johngmyers johngmyers deleted the topology branch July 19, 2023 17:50
@johngmyers johngmyers mentioned this pull request Jul 21, 2023
Merged
@clayrisser
Copy link

Why was nodes and controlPlane topology fields removed? How can I configure controlPlane to have a public topology now?

@johngmyers
Copy link
Member Author

The topology fields didn't do much of anything. You configure the topology by specifying the subnets for the particular instance groups.

@clayrisser
Copy link

Ok, thanks. Got it to work!

https://gitlab.com/bitspur/rock8s/rock8s-cluster

Sorry haven't updated the code here yet.
https://github.com/clayrisser/rock8s-cluster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/documentation area/nodeup area/provider/openstack Issues or PRs related to openstack provider area/rolling-update cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@johngmyers @k8s-ci-robot @hakman @clayrisser