Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass S3_* env vars to nodes when using Gossip #15691

Closed
wants to merge 1 commit into from
Closed

Pass S3_* env vars to nodes when using Gossip #15691

wants to merge 1 commit into from

Conversation

hakman
Copy link
Member

@hakman hakman commented Jul 22, 2023

Closes #15684

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hakman. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 22, 2023
@hakman hakman mentioned this pull request Jul 22, 2023
Closed
@hakman
Copy link
Member Author

hakman commented Jul 22, 2023

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2023
@hakman
Copy link
Member Author

hakman commented Jul 22, 2023

/cc @justinsb
/assign @justinsb

johngmyers
johngmyers reviewed Jul 22, 2023
View reviewed changes
Copy link
Member

@johngmyers johngmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we suppress the credentials entirely when the cloud provider has an instance role or equivalent?

We should be moving the non-credential stuff to the cluster spec.

@hakman
Copy link
Member Author

hakman commented Jul 22, 2023

Can we suppress the credentials entirely when the cloud provider has an instance role or equivalent?
We should be moving the non-credential stuff to the cluster spec.

Not sure what you mean, but closing this for now. It should not be needed.

@hakman hakman closed this Jul 22, 2023
@hakman hakman deleted the s3_gossip branch July 22, 2023 13:58
@ederst ederst mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers left review comments

@olemarkus olemarkus Awaiting requested review from olemarkus

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@justinsb justinsb

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

S3 config lost in openstack for worker nodes
4 participants
@hakman @k8s-ci-robot @johngmyers @justinsb