Automated cherry pick of #15674: kubetest2-kops: rename control-plane-size flag to #15718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency with kops create cluster. It doesn't appear to be used outside this repo, although test-infra declares KOPS_CONTROL_PLANE_SIZE and that is then passed to our e2e/scenarios scripts. Issue kubernetes#15559
We still accept KOPS_CONTROL_PLANE_SIZE (for now), but we should be switching to KOPS_CONTROL_PLANE_COUNT
Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>
k8s-ci-robot
added
cncf-cla: yes
hakman
approved these changes
Jul 30, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #15674 on release-1.26.
#15674: kubetest2-kops: rename control-plane-size flag to
For details on the cherry pick process, see the cherry pick requests page.