Refactor: Replace ForAPIServer with WellKnownServices #15829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
/milestone v1.29 |
k8s-ci-robot
added
area/provider/aws
johngmyers
reviewed
Aug 26, 2023
pkg/model/bootstrapscript.go
Outdated
| } | ||
|
|
||
| // WellKnownAddresses holds known addresses for well-known services | ||
| type WellKnownAddresses struct { |
There was a problem hiding this comment.
Perhaps something more like a map[wellknownservices.WellKnownService][]string?
There was a problem hiding this comment.
Good idea - converted to a type alias on the map.
k8s-ci-robot
added
the
needs-rebase
justinsb
force-pushed
the
refactor_forapiserver
branch
from
00b8915
to
1baeef3
Compare
k8s-ci-robot
removed
the
needs-rebase
|
I remembered why this one is important ... doing this will let us set up two apiservers, one for internal traffic and one for external traffic, which is needed for GCE firewalling, which is needed for GCE dns=none |
We instead return a list of the services we are supporting. We can in future split out internal and external apiserver services.
justinsb
force-pushed
the
refactor_forapiserver
branch
from
1baeef3
to
ae226db
Compare
k8s-ci-robot
added
size/XL
|
/test pull-kops-e2e-k8s-aws-calico |
justinsb
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
hakman
approved these changes
Jan 20, 2024
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We instead return a list of the services we are supporting.
We can in future split out internal and external apiserver services.