-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scaleway: terraform support #15892
scaleway: terraform support #15892
Conversation
Hi @Mia-Cross. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
5c297e2
to
dcc4d1f
Compare
dcc4d1f
to
8ead37c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mia-Cross mostly LGTM, with a few small nits. Could you take a look?
upup/pkg/fi/cloudup/apply_cluster.go
Outdated
if cluster.Spec.GetCloudProvider() == kops.CloudProviderScaleway { | ||
shouldPrecreateDNS = true | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During dry-run should not pre-create DNS records.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I meant to write this line in the Terraform part and not the DryRun part.
This may be temporary as I am considering creating a model and a task for the DNS record resource. But I have not had any conflict if I pre-create DNS records even for Terraform clusters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove it from here? I don't want to forget about it and have different behaviour from other cloud providers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The model and task for DNS record are ready. I removed the exception for the pre-creation of DNS records with Terraform from apply_cluster.go
.
Instead the records get pre-created in the kubernetes.tf
file with the placeholder IP and with ignore_changes
on the data
field because its value will be changed outside of Terraform (similar to the way the etcd volumes are handled)
8ead37c
to
9e1696f
Compare
/retest |
… at cluster deletion
9e1696f
to
6994816
Compare
6994816
to
6890c58
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Mia-Cross, LGTM!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds the support for the generation of Terraform files when creating and updating clusters.