Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go to v1.21.1 #15893

Merged
merged 1 commit into from Sep 9, 2023
Merged

Update Go to v1.21.1 #15893

merged 1 commit into from Sep 9, 2023

Conversation

hakman
Copy link
Member

@hakman hakman commented Sep 8, 2023

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 8, 2023
@rifelpet
Copy link
Member

rifelpet commented Sep 9, 2023

Should we bump the go.mod version too?

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 9, 2023
@hakman
Copy link
Member Author

hakman commented Sep 9, 2023

@rifelpet Updated go.mod also. Thanks!

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 9, 2023
@hakman
Copy link
Member Author

hakman commented Sep 9, 2023

Seems that we can't for now kubekins-e2e is still on Go 1.20.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit 376cd32 into kubernetes:master Sep 9, 2023
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 9, 2023
@hakman hakman deleted the go-1.21.1 branch September 9, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants