scale-test: Optimise node dumping for large clusters #15934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
hakman
force-pushed
the
optimize_test_cleanup
branch
2 times, most recently
from
7c0b2ec
to
3d3cfd9
Compare
justinsb
reviewed
Sep 20, 2023
pkg/dump/dumper.go
Outdated
| @@ -34,6 +34,11 @@ import ( | |||
| "k8s.io/klog/v2" | |||
| ) | |||
|
|
|||
| const ( | |||
| // MaxDumped is the maximum number of nodes to dump | |||
| MaxDumped = 500 | |||
There was a problem hiding this comment.
Nit: MaxNodesToDump might be clearer
|
One naming nit, generally lgtm! |
hakman
force-pushed
the
optimize_test_cleanup
branch
from
3d3cfd9
to
e8be137
Compare
k8s-ci-robot
added
size/L
hakman
force-pushed
the
optimize_test_cleanup
branch
from
9d873f2
to
3beab45
Compare
k8s-ci-robot
added
size/M
hakman
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/approve |
k8s-ci-robot
added
the
approved
hakman
force-pushed
the
optimize_test_cleanup
branch
from
3beab45
to
5c78560
Compare
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @dims @justinsb @rifelpet