Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting map[string]string from the command line #15989

Merged
merged 1 commit into from Oct 3, 2023
Merged

Allow setting map[string]string from the command line #15989

merged 1 commit into from Oct 3, 2023

Conversation

hakman
Copy link
Member

@hakman hakman commented Oct 3, 2023 •
edited 

> kops create cluster \
    --set spec.kubeAPIServer.runtimeConfig=extensions/v1beta1=true \
    --set spec.kubeAPIServer.runtimeConfig=scheduling.k8s.io/v1alpha1=true
...

> kops get cluster -o yaml
...
  kubeAPIServer:
    runtimeConfig:
      extensions/v1beta1: "true"
      scheduling.k8s.io/v1alpha1: "true"
...

/cc @upodroid

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 3, 2023
@hakman
Copy link
Member Author

hakman commented Oct 3, 2023

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2023
@hakman hakman mentioned this pull request Oct 3, 2023
Open
upodroid
upodroid approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

I'll rebase the alpha PR with this change

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2023
@hakman
Copy link
Member Author

hakman commented Oct 3, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit ed6edaf into kubernetes:master Oct 3, 2023
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 3, 2023
@hakman hakman deleted the set-string-map branch October 3, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid approved these changes

Assignees

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hakman @k8s-ci-robot @upodroid