Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloud-platform GCP VM scope #16013

Merged

Conversation

sl1pm4t
Copy link
Contributor

@sl1pm4t sl1pm4t commented Oct 11, 2023

This changes adds the cloud-platform scope to the GCP instances created by kOps.
This is the Google recommended best practice, and it allows setting instance permissions via the IAM roles granted to the Service Account associated with the VM.

Also, code comments in kops indicate this a desirable change.

In our case, we needed the bastion nodes to be able to read secrets out of Google Secret Manager, which the current VM scopes wouldn't have allowed.

Closes #11768

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 11, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 11, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @sl1pm4t!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @sl1pm4t. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 11, 2023
@zetaab
Copy link
Member

zetaab commented Oct 11, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 11, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2023
@sl1pm4t
Copy link
Contributor Author

sl1pm4t commented Oct 11, 2023

/retest

@sl1pm4t
Copy link
Contributor Author

sl1pm4t commented Oct 11, 2023

/retest-required

@hakman
Copy link
Member

hakman commented Oct 12, 2023

Thanks @sl1pm4t! 😄
/lgtm
/ok-to-test
/cc @justinsb
/assign @justinsb
/kind office-hours

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2023
@hakman
Copy link
Member

hakman commented Oct 12, 2023

/retest

@justinsb
Copy link
Member

Thanks for bringing us out of scope era @sl1pm4t - this is a good change :-)

We had some discussion about whether we should drop the other scopes (as they're included in the new scope); they seem harmless and it's probably a good idea to be explicit in case anyone is looking for those particular scope values.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2023
@justinsb
Copy link
Member

/test pull-kops-e2e-k8s-gce-cilium

@k8s-ci-robot k8s-ci-robot merged commit dd7a3a6 into kubernetes:master Oct 20, 2023
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 20, 2023
@sl1pm4t sl1pm4t deleted the enable-gcp-cloud-platform-scope branch November 6, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/office-hours lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCP MIG templates created with limited scopes (not full serviceAccount access)
5 participants