New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cloud-platform GCP VM scope #16013
Add cloud-platform GCP VM scope #16013
Conversation
Welcome @sl1pm4t! |
Hi @sl1pm4t. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
/retest-required |
/retest |
Thanks for bringing us out of scope era @sl1pm4t - this is a good change :-) We had some discussion about whether we should drop the other scopes (as they're included in the new scope); they seem harmless and it's probably a good idea to be explicit in case anyone is looking for those particular scope values. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kops-e2e-k8s-gce-cilium |
This changes adds the
cloud-platform
scope to the GCP instances created by kOps.This is the Google recommended best practice, and it allows setting instance permissions via the IAM roles granted to the Service Account associated with the VM.
Also, code comments in kops indicate this a desirable change.
In our case, we needed the bastion nodes to be able to read secrets out of Google Secret Manager, which the current VM scopes wouldn't have allowed.
Closes #11768