Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gce: Add support for publishing Service Account Issuer documents to GCS #16050

Merged
merged 1 commit into from Dec 3, 2023

Conversation

sl1pm4t
Copy link
Contributor

@sl1pm4t sl1pm4t commented Oct 23, 2023

This change adds for support for GCS as a target for cluster.spec.serviceAccountIssuerDiscovery.discoveryStore.

The generated service account issuer URL will then be in the form:
https://storage.googleapis.com/<BUCKET>
meaning the JWKS URI becomes:
https://storage.googleapis.com/<BUCKET>/openid/v1/jwks

This is the first step towards supporting Workload Identity on GCP kOps clusters.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 23, 2023
@k8s-ci-robot k8s-ci-robot added area/api area/documentation needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 23, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @sl1pm4t. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 23, 2023
@hakman
Copy link
Member

hakman commented Oct 23, 2023

/ok-to-test
/cc @justinsb
/assign @justinsb

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 23, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 23, 2023
@hakman hakman changed the title Add support for publishing Service Account Issuer documents to GCS. gce: Add support for publishing Service Account Issuer documents to GCS Oct 24, 2023
@justinsb
Copy link
Member

justinsb commented Dec 2, 2023

Thank you @sl1pm4t - looks great!

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit a4bd641 into kubernetes:master Dec 3, 2023
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Dec 3, 2023
@sl1pm4t sl1pm4t deleted the gcp-sa-issuer branch December 3, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants