Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws: Skip ASG cleanup on Karpenter managed IG deletion #16051

Merged
merged 1 commit into from Oct 24, 2023
Merged

aws: Skip ASG cleanup on Karpenter managed IG deletion #16051

merged 1 commit into from Oct 24, 2023

Conversation

hakman
Copy link
Member

@hakman hakman commented Oct 24, 2023

Closes #16048

/cc @olemarkus

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2023
@hakman hakman marked this pull request as ready for review October 24, 2023 06:09
@k8s-ci-robot k8s-ci-robot added area/provider/aws Issues or PRs related to aws provider and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 419b93b into kubernetes:master Oct 24, 2023
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 24, 2023
@hakman hakman deleted the karpenter_delete_ig branch October 24, 2023 07:43
This was referenced Oct 24, 2023
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Oct 24, 2023
@k8s-ci-robot
Merge pull request #16052 from hakman/automated-cherry-pick-of-#16051…
ec8bb48 
…-upstream-release-1.28

Automated cherry pick of #16051: aws: Skip ASG cleanup on Karpenter managed IG deletion
k8s-ci-robot added a commit that referenced this pull request Oct 24, 2023
@k8s-ci-robot
Merge pull request #16053 from hakman/automated-cherry-pick-of-#16051…
5f8d48f 
…-upstream-release-1.27

Automated cherry pick of #16051: aws: Skip ASG cleanup on Karpenter managed IG deletion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet approved these changes

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

Deleting Karpenter managed instance group cause panic
3 participants
@hakman @k8s-ci-robot @rifelpet