Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toolbox dump: include AWS route table objects #16073

Merged
merged 1 commit into from Nov 6, 2023
Merged

toolbox dump: include AWS route table objects #16073

merged 1 commit into from Nov 6, 2023

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Nov 1, 2023

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 1, 2023
@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Nov 1, 2023
@justinsb
Copy link
Member Author

justinsb commented Nov 1, 2023

This "can't" be the fix, but #16072 passed with this included. I think the cloud-init change is more likely to be the cause (though that doesn't make a lot of sense), but this can serve as our "control"

/test pull-kops-e2e-cni-calico-ipv6

@justinsb
Copy link
Member Author

justinsb commented Nov 1, 2023

/wip so that it doesn't merge, I don't think it's particularly time-critical

@hakman
Copy link
Member

hakman commented Nov 1, 2023

/wip

@hakman hakman changed the title dump: include AWS route table objects WIP dump: include AWS route table objects Nov 1, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2023
@justinsb justinsb changed the title WIP dump: include AWS route table objects toolbox dump: include AWS route table objects Nov 6, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 6, 2023
@justinsb
Copy link
Member Author

justinsb commented Nov 6, 2023 •
edited

This turned out not to be related to the IPv6 test failures, but I think we should be dumping all these objects. Debating whether we should just default the Dump function, but as we still have to set object I though a bit of repetition here wasn't the end of the world.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit f44ee89 into kubernetes:master Nov 6, 2023
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@olemarkus olemarkus Awaiting requested review from olemarkus

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justinsb @hakman @k8s-ci-robot