Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit jobname value to 80 #16136

Merged
merged 1 commit into from Nov 30, 2023
Merged

Conversation

upodroid
Copy link
Member

Limit jobName length 80 to avoid long job names from failing.

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/e2e-ci-kubernetes-e2e-al2023-aws-conformance-aws-cni-canary/1730167438948962304

Error: error running tasks: deadline exceeded executing task SQS/e2e-e2e-ci-kubernetes-e2e-al2023-aws-conformance-aws-cni-canary-test-cncf-aws-k8s-io-nth. Example error: error creating SQS queue: InvalidParameterValue: Can only include alphanumeric characters, hyphens, or underscores. 1 to 80 in length

/cc @hakman @dims

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 30, 2023
@dims
Copy link
Member

dims commented Nov 30, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2023
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6f7fcb0 into kubernetes:master Nov 30, 2023
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants