Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boskos-resource-type flag to use different GCE projects for scale/gpu testing #16268

Merged
merged 1 commit into from Jan 27, 2024

Conversation

upodroid
Copy link
Member

Required for #16181

When we are running scale/gpu tests, we need to use a dedicated pool of GCE projects called scalability-project, scalability-scale-project and gpu-project. This PR adds support for that feature.

Defined here https://github.com/kubernetes/k8s.io/blob/main/infra/gcp/terraform/k8s-infra-prow-build/prow-build/resources/test-pods/boskos-resources-configmap.yaml#L174

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 21, 2024
@upodroid upodroid changed the title Add boskos-resource-type flag to use different GCE projects for scale/gpu testing Add boskos-resource-type flag to use different GCE projects for scale/gpu testing Jan 21, 2024
@upodroid
Copy link
Member Author

/cc @hakman

@hakman
Copy link
Member

hakman commented Jan 26, 2024

/cc @justinsb
/assign @justinsb

@upodroid
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 825e9cc into kubernetes:master Jan 27, 2024
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants