Set KUBECONFIG for LBC's ginkgo tests #16334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
hakman
reviewed
Feb 10, 2024
| @@ -33,6 +33,9 @@ ZONES="eu-west-1a,eu-west-1b,eu-west-1c" | |||
|
|
|||
| kops-up | |||
|
|
|||
| export KUBECONFIG=$(mktemp -t kops.XXXXXXXXX) | |||
There was a problem hiding this comment.
https://www.shellcheck.net/wiki/SC2155
Suggested change
| export KUBECONFIG=$(mktemp -t kops.XXXXXXXXX) | |
| KUBECONFIG=$(mktemp -t kops.XXXXXXXXX) | |
| export KUBECONFIG |
There was a problem hiding this comment.
I believe so because the ginkgo process is what is loading the client-go config and reading from the KUBECONFIG env var, not just a shell variable.
rifelpet
force-pushed
the
lbc-kubecfg
branch
from
0741918
to
b73a2dd
Compare
hakman
approved these changes
Feb 10, 2024
k8s-ci-robot
added
the
lgtm
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoping to fix these tests: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/e2e-kops-aws-aws-load-balancer-controller/1755828286962798592
The test failures seem to be using the wrong kubeconfig settings, potentially using the "in cluster" config of the prow job pod itself.
This explicitly sets KUBECONFIG so that the ginkgo tests will use the kops cluster's admin credentials
ref: https://kubernetes.slack.com/archives/C8MKE2G5P/p1707502477184889?thread_ts=1707242089.155659&cid=C8MKE2G5P