validation: Allow overlap of pod/node CIDR and service CIDR #16344
+114
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We allowed this previously, so this is a regression for existing clusters. These clusters are not obviously broken, and the kube-controller-manager (for example) will exclude the service range when issuing node CIDRs. As such, remove validation until we can determine if anything is actually broken by an overlap (and a path forwards if so). Issue kubernetes#16340
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/L
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 11, 2024
…-upstream-release-1.28 Cherry pick of #16344: validation: Allow overlap of pod/node CIDR and service CIDR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We allowed this previously, so this is a regression for existing clusters.
These clusters are not obviously broken, and the
kube-controller-manager (for example) will exclude the service range
when issuing node CIDRs. As such, remove validation until we can
determine if anything is actually broken by an overlap (and a path
forwards if so).
Issue #16340