Include /etc/hosts coredns mounts for dns=none clusters #16347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
rifelpet
commented
Feb 11, 2024
| @@ -76,7 +76,7 @@ data: | |||
| fallthrough in-addr.arpa ip6.arpa | |||
| ttl 30 | |||
| } | |||
| {{- if GossipName }} | |||
| {{- if not PublishesDNSRecords }} | |||
| hosts /rootfs/etc/hosts k8s.local { | |||
There was a problem hiding this comment.
/hold Actually this needs to be updated to the cluster's domain
k8s-ci-robot
added
the
do-not-merge/hold
rifelpet
force-pushed
the
dnsnone-coredns
branch
from
430411e
to
605f791
Compare
k8s-ci-robot
removed
the
do-not-merge/hold
hakman
approved these changes
Feb 11, 2024
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
|
Confirmed this fixed the e2e failures: https://testgrid.k8s.io/kops-grid#kops-grid-calico-flatcar-k28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #16335 (comment)