Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure: Avoid spurious changes in VirtualNetwork #16358

Merged
merged 2 commits into from Feb 17, 2024

Conversation

hakman
Copy link
Member

@hakman hakman commented Feb 17, 2024

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 17, 2024
@hakman
Copy link
Member Author

hakman commented Feb 17, 2024

/cc @rifelpet @justinsb

@k8s-ci-robot k8s-ci-robot added the area/provider/azure Issues or PRs related to azure provider label Feb 17, 2024
@justinsb
Copy link
Member

Agreed - having the subnet field also makes the planner think there's a dependency

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5607c66 into kubernetes:master Feb 17, 2024
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants