chore: update dependencies in submodules #16372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
hakman
requested changes
Feb 22, 2024
Makefile
Outdated
|
|
||
| .PHONY: goget | ||
| goget: | ||
| go get $(shell go list -f '{{if not (or .Main .Indirect)}}{{.Path}}{{end}}' -mod=mod -m all | grep -v spotinst-sdk-go) | ||
| cd hack; go get $(shell go list -f '{{if not (or .Main .Indirect)}}{{.Path}}{{end}}' -mod=mod -m all | grep -v spotinst-sdk-go) | ||
| cd tests/e2e; go get $(shell go list -f '{{if not (or .Main .Indirect)}}{{.Path}}{{end}}' -mod=mod -m all | grep -v spotinst-sdk-go) |
There was a problem hiding this comment.
I don't think I want ginkgo and kubetest updated, at least not as part of this flow.
Also, we need to remove grep -v spotinst-sdk-go everywhere.
There was a problem hiding this comment.
Done; we don't import ginkgo directly anywhere, and we only import kubetest2 in one submodule; added the exclusion there.
Our submodules should also get auto-updated and auto-tidied by the Makefile targets; this should then be done automatically by our github action scheduled task.
justinsb
force-pushed
the
expand_goget
branch
from
0c8cf94
to
7cc3147
Compare
hakman
approved these changes
Feb 24, 2024
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
|
/test all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our submodules should also get auto-updated and auto-tidied by the
Makefile targets; this should then be done automatically by our github
action scheduled task.