Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation to help users move from usePolicyConfigMap #16391

Merged
merged 1 commit into from Feb 29, 2024

Conversation

hakman
Copy link
Member

@hakman hakman commented Feb 28, 2024

/cc @justinsb @rifelpet

Fixes #16388

https://kubernetes.io/docs/reference/scheduling/policies/

In Kubernetes versions before v1.23, a scheduling policy can be used to specify the predicates and priorities process. For example, you can set a scheduling policy by running kube-scheduler --policy-config-file or kube-scheduler --policy-configmap .
This scheduling policy is not supported since Kubernetes v1.23. Associated flags policy-config-file, policy-configmap, policy-configmap-namespace and use-legacy-policy-config are also not supported. Instead, use the Scheduler Configuration to achieve similar behavior.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/api area/nodeup labels Feb 28, 2024
@hakman hakman force-pushed the deprecate-UsePolicyConfigMap branch from 1721f28 to 66d4e9b Compare February 28, 2024 19:58
@k8s-ci-robot k8s-ci-robot added area/addons size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 28, 2024
@hakman
Copy link
Member Author

hakman commented Feb 29, 2024

/retest

@justinsb
Copy link
Member

Oh ... 1.23!!! Never mind, that's very outside of our support window :-)

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit c0cef47 into kubernetes:master Feb 29, 2024
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/api area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kube-scheduler pod goes into CrashLoopBackOff status because of incorrect arguments
3 participants