Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #16177: Bump cert manager to 1.12.7 #16399

Conversation

idealhack
Copy link
Member

Cherry pick of #16177 on release-1.28.

#16177: bump cert manager to 1.12.7

For details on the cherry pick process, see the cherry pick requests page.


@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Mar 11, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 11, 2024
@hakman hakman changed the title Automated cherry pick of #16177: bump cert manager to 1.12.7 Automated cherry pick of #16177: Bump cert manager to 1.12.7 Mar 11, 2024
@hakman
Copy link
Member

hakman commented Mar 11, 2024

@idealhack Thanks for the cherry-pick. Could you run hack/update-expected.sh and commit the changes to update the output?

@hakman
Copy link
Member

hakman commented Mar 12, 2024

Thanks @idealhack! If you want to create a PR to bump it to 1.12.9, I would be happy to review that one also. 😄
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit cd5d6a3 into kubernetes:release-1.28 Mar 12, 2024
13 checks passed
@idealhack
Copy link
Member Author

idealhack commented Mar 17, 2024

@hakman Yeah, I like that! I filed a PR based on master branch #16410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants