Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws: Experiment with Adaptive retry mode #16580

Merged
merged 1 commit into from
May 19, 2024
Merged

aws: Experiment with Adaptive retry mode #16580

merged 1 commit into from
May 19, 2024

Conversation

hakman
Copy link
Member

@hakman hakman commented May 19, 2024

aws/aws-sdk-go-v2#1576 introduced support for the experimental Adaptive retry mode to the SDK.

The adaptive retryer expands on the exponential backoff retry strategies of the Standard mode, adding client attempt rate limiting based on throttle responses received from an API.

This may help fix the Scalability tests that are now failing:
https://testgrid.k8s.io/sig-scalability-aws#ec2-master-scale-performance

instance:i-06b9c1de0b89a3499 error deleting resources, will retry: error terminating instances: operation error EC2: TerminateInstances, failed to get rate limit token, retry quota exceeded, 0 available, 5 requested

/cc @dims @hakuna-matatah @rifelpet @zetaab

@k8s-ci-robot k8s-ci-robot added area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 19, 2024
@dims
Copy link
Member

dims commented May 19, 2024

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2024
@hakman
Copy link
Member Author

hakman commented May 19, 2024

/retest

@k8s-ci-robot k8s-ci-robot merged commit fc91085 into kubernetes:master May 19, 2024
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone May 19, 2024
@hakman hakman deleted the aws_retry_adaptive branch May 19, 2024 14:08
@dims dims mentioned this pull request May 20, 2024
Closed
@dims
Copy link
Member

dims commented May 20, 2024

xref: kubernetes/kubernetes#124951

@hakuna-matatah
Copy link
Contributor

hakuna-matatah commented May 20, 2024 •
edited
Loading

Thanks for linking this issue for tracking @dims, I was following up on scale test failures last week with @hakman on the same on k8s slack :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet approved these changes

@dims dims Awaiting requested review from dims

@hakuna-matatah hakuna-matatah Awaiting requested review from hakuna-matatah

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@dims dims

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hakman @dims @k8s-ci-robot @hakuna-matatah @rifelpet